Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate did:web REST endpoint #1437

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Aug 22, 2022

Included:

  • Add new handle to operations for /scid/{id}/did.json
  • Add cases for unpublished and deactivated to WebResolver
  • Add BDD tests

Closes #1427

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Aug 22, 2022
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1437 (05a1ee1) into main (7a9e18e) will decrease coverage by 0.01%.
The diff coverage is 87.17%.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
- Coverage   87.92%   87.90%   -0.02%     
==========================================
  Files         208      208              
  Lines       19567    19635      +68     
==========================================
+ Hits        17204    17261      +57     
- Misses       1505     1515      +10     
- Partials      858      859       +1     
Impacted Files Coverage Δ
pkg/metrics/metrics.go 99.67% <72.72%> (-0.33%) ⬇️
pkg/discovery/endpoint/restapi/operations.go 88.21% <78.57%> (-0.39%) ⬇️
pkg/document/webresolver/resolvehandler.go 90.80% <92.00%> (+3.57%) ⬆️
cmd/orb-server/startcmd/start.go 68.65% <100.00%> (-0.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sandrask sandrask changed the title feat: Integrate did:web REST endpoint wip: Integrate did:web REST endpoint Aug 22, 2022
@sandrask sandrask changed the title wip: Integrate did:web REST endpoint feat: Integrate did:web REST endpoint Aug 23, 2022
Included:
- Add new handle to operations for /scid/{id}/did.json
- Add cases for unpublished and deactivated to WebResolver
- Add BDD tests

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask merged commit ce26147 into trustbloc:main Aug 23, 2022
This was linked to issues Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create did:web BDD test did:web REST endpoint Transform did:orb to did:web rules
3 participants