Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add equivalent ID to also known as for did:web #1446

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

sandrask
Copy link
Contributor

For unpublished documents there is only one equivalent ID (with domain) so we will use that one.
For published documents we will use first (HL one).

Closes #1441

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

For unpublished documents there is only one equivalent ID (with domain) so we will use that one.
For published documents we will use first (HL one).

Closes trustbloc#1441

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #1446 (7c4c596) into main (dcf5623) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
+ Coverage   87.88%   87.91%   +0.02%     
==========================================
  Files         208      208              
  Lines       19635    19658      +23     
==========================================
+ Hits        17256    17282      +26     
+ Misses       1518     1516       -2     
+ Partials      861      860       -1     
Impacted Files Coverage Δ
pkg/document/webresolver/resolvehandler.go 92.72% <100.00%> (+1.92%) ⬆️
pkg/observer/pubsub.go 94.49% <0.00%> (ø)
pkg/vct/proofmonitoring/monitoring.go 86.72% <0.00%> (+2.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fqutishat fqutishat merged commit 2af19b7 into trustbloc:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add one orb:did equivalent ID to did:web also known as
2 participants