fix: Panic in HTTP subscriber Stop #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a publisher channel to handle publish requests in a separate Go proc. When the HTTP subscriber is stopped, the publisher listener safely shuts down the subscriber channel. This commit also fixes the problem with varying code coverage in the unit tests and a race condition in the startup params test. closes trustbloc#1463 closes trustbloc#591 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
sandrask
approved these changes
Aug 30, 2022
fqutishat
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a publisher channel to handle publish requests in a separate Go proc. When the HTTP subscriber is stopped, the publisher listener safely shuts down the subscriber channel.
This commit also fixes the problem with varying code coverage in the unit tests.
closes #1463
closes #591
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com