Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VerifyWebDocumentFromOrbDocument to orb client #1472

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

sandrask
Copy link
Contributor

VerifyWebDocumentFromOrbDocument will create web document from orb resolution result and compare that web document with provided web document for equality.

Also, add BDD test.

Closes #1374

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #1472 (d1d1cc5) into main (7125f6a) will decrease coverage by 0.00%.
The diff coverage is 78.94%.

@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
- Coverage   87.84%   87.83%   -0.01%     
==========================================
  Files         209      209              
  Lines       19740    19759      +19     
==========================================
+ Hits        17340    17355      +15     
- Misses       1543     1545       +2     
- Partials      857      859       +2     
Impacted Files Coverage Δ
pkg/orbclient/doctransformer/transformer.go 87.75% <78.94%> (-2.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

VerifyWebDocumentFromOrbDocument will create web document from orb resolution result and compare that web document with provided web document for equality.

Also, add BDD test.

Closes trustbloc#1374

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@fqutishat fqutishat merged commit 008fee0 into trustbloc:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When resolving a DID document that has alsoKnownAs, verify the resolution with orb
4 participants