Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only add JSON-LD contexts that are referenced in the proof #1478

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

bstasyszyn
Copy link
Contributor

closes #1471

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1478 (32f9c7e) into main (dc4be2e) will increase coverage by 0.13%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   87.80%   87.94%   +0.13%     
==========================================
  Files         210      210              
  Lines       19703    19793      +90     
==========================================
+ Hits        17300    17406     +106     
+ Misses       1544     1525      -19     
- Partials      859      862       +3     
Impacted Files Coverage Δ
cmd/orb-cli/vctcmd/verifycmd.go 74.53% <61.11%> (ø)
pkg/vct/proofmonitoring/monitoring.go 83.73% <96.15%> (-0.34%) ⬇️
pkg/anchor/handler/proof/handler.go 90.22% <100.00%> (+12.44%) ⬆️
pkg/vcsigner/signer.go 98.09% <100.00%> (+8.98%) ⬆️
pkg/vct/logmonitoring/monitor.go 94.31% <100.00%> (ø)
pkg/vct/vct.go 86.46% <100.00%> (ø)
pkg/multihash/multihash.go 83.33% <0.00%> (-11.12%) ⬇️
pkg/store/operation/unpublished/store.go 95.83% <0.00%> (-4.17%) ⬇️
cmd/orb-cli/createdidcmd/createdid.go 91.85% <0.00%> (-0.02%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

closes trustbloc#1471

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@fqutishat fqutishat merged commit 0ecec00 into trustbloc:main Sep 13, 2022
@bstasyszyn bstasyszyn deleted the 1471 branch September 13, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anchor credential includes unused context
3 participants