fix: Make VC issuer the same as author of anchor linkset #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrask
approved these changes
Sep 20, 2022
Codecov ReportBase: 87.93% // Head: 87.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 87.93% 87.97% +0.04%
==========================================
Files 210 210
Lines 19827 19824 -3
==========================================
+ Hits 17435 17441 +6
+ Misses 1528 1522 -6
+ Partials 864 861 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The issuer in the anchor credential (VC) is now always the same as the author of the anchor linkset. So if the auther is a DID then the issuer will be set to the same DID. This commit also removes the startup parameters, anchor-credential-issuer and anchor-credential-url since they are redundant and can also lead to misconfiguration. closes trustbloc#1488 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
fqutishat
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issuer in the anchor credential (VC) is now always the same as the author of the anchor linkset. So if the auther is a DID then the issuer will be set to the same DID.
This commit also removes the startup parameters, anchor-credential-issuer and anchor-credential-url since they are redundant and can also lead to misconfiguration.
closes #1488
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com