feat: Convert ActivityPub subsystem to use structured logs #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 88.01% // Head: 87.94% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
- Coverage 88.01% 87.94% -0.07%
==========================================
Files 214 216 +2
Lines 20112 20286 +174
==========================================
+ Hits 17701 17841 +140
- Misses 1539 1571 +32
- Partials 872 874 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fqutishat
approved these changes
Sep 27, 2022
The ActivityPub subsystem now uses key-value pairs for additional data (as opposed to embedding values into the log message). Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
bstasyszyn
force-pushed
the
structuredlog
branch
from
31e40bf
to
8bf6fd9
Compare
bstasyszyn
changed the title
DRK3
reviewed
Sep 27, 2022
| log("Error closing iterator", WithError(err)) | ||
| } | ||
|
|
||
| // CloseResponseBody outputs an 'close respojnse body' error log to the given logger. |
sandrask
approved these changes
Sep 27, 2022
DRK3
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActivityPub subsystem now uses key-value pairs for additional data (as opposed to embedding values into the log message).
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com