Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panic in auth handler for DELETE and PUT methods #1526

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

bstasyszyn
Copy link
Contributor

Also cleaned up the auth token definition in the BDD test to remove invalid endpoint.

closes #1523

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Also cleaned up the auth token definition in the BDD test to remove invalid endpoint.

closes trustbloc#1523

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 88.12% // Head: 88.10% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (e32622f) compared to base (b1c91fc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1526      +/-   ##
==========================================
- Coverage   88.12%   88.10%   -0.02%     
==========================================
  Files         219      219              
  Lines       20846    20846              
==========================================
- Hits        18370    18366       -4     
- Misses       1582     1585       +3     
- Partials      894      895       +1     
Impacted Files Coverage Δ
pkg/httpserver/auth/tokenverifier.go 93.82% <100.00%> (ø)
pkg/vct/proofmonitoring/monitoring.go 81.06% <0.00%> (-3.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bstasyszyn bstasyszyn merged commit effd386 into trustbloc:main Nov 17, 2022
@bstasyszyn bstasyszyn deleted the 1523 branch November 17, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorization handler panics on DELETE HTTP method
3 participants