fix: Orb client document verification fails for deactivated document #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Input and resolved documents are the same however metadata check fails due to missing updateCommitment. We should not be checking commitments for deactivated document since they are not available. Closes trustbloc#1529 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov ReportBase: 88.09% // Head: 88.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1530 +/- ##
==========================================
+ Coverage 88.09% 88.11% +0.02%
==========================================
Files 220 220
Lines 20885 20900 +15
==========================================
+ Hits 18398 18417 +19
+ Misses 1590 1587 -3
+ Partials 897 896 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fqutishat
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input and resolved documents are the same however metadata check fails due to missing updateCommitment.
We should not be checking commitments for deactivated document since they are not available.
Closes #1529
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com