Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MongoDB cursor leak #1544

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

bstasyszyn
Copy link
Contributor

Close various DB iterators after use.

@cla-bot cla-bot bot added the cla-signed label Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 85.29% and no project coverage change.

Comparison is base (0ab7a12) 88.22% compared to head (dbf7bc9) 88.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1544   +/-   ##
=======================================
  Coverage   88.22%   88.22%           
=======================================
  Files         226      226           
  Lines       21087    21108   +21     
=======================================
+ Hits        18603    18623   +20     
- Misses       1589     1591    +2     
+ Partials      895      894    -1     
Impacted Files Coverage Δ
pkg/store/store.go 96.59% <0.00%> (-2.02%) ⬇️
pkg/activitypub/store/ariesstore/ariesstore.go 88.57% <85.71%> (+0.33%) ⬆️
pkg/activitypub/service/acceptlist/acceptlist.go 88.79% <100.00%> (+0.09%) ⬆️
...ctivitypub/service/activityhandler/inboxhandler.go 83.60% <100.00%> (+0.02%) ⬆️
...vitypub/service/anchorsynctask/activitysynctask.go 88.48% <100.00%> (+0.06%) ⬆️
pkg/activitypub/service/outbox/outbox.go 91.09% <100.00%> (+0.02%) ⬆️
...owedorigins/allowedoriginsmgr/allowedoriginsmgr.go 100.00% <100.00%> (ø)
pkg/anchor/linkstore/linkstore.go 94.93% <100.00%> (+0.06%) ⬆️
pkg/nodeinfo/service.go 91.80% <100.00%> (+1.48%) ⬆️
pkg/store/anchorstatus/store.go 89.52% <100.00%> (+0.16%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Close various DB iterators after use.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn merged commit 4d216c1 into trustbloc:main Apr 20, 2023
12 checks passed
@bstasyszyn bstasyszyn deleted the mongocursorleak branch April 20, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants