Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set expiryTime field on detached operation #1568

Merged
merged 1 commit into from
May 29, 2023

Conversation

bstasyszyn
Copy link
Contributor

closes #1567

closes trustbloc#1567

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label May 28, 2023
@bstasyszyn bstasyszyn changed the title fix: Set expirtyTime field on detached operation fix: Set expiryTime field on detached operation May 28, 2023
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: -0.01 ⚠️

Comparison is base (e01c15c) 88.17% compared to head (af348ed) 88.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1568      +/-   ##
==========================================
- Coverage   88.17%   88.16%   -0.01%     
==========================================
  Files         227      227              
  Lines       21483    21485       +2     
==========================================
+ Hits        18942    18943       +1     
  Misses       1634     1634              
- Partials      907      908       +1     
Impacted Files Coverage Δ
cmd/orb-server/startcmd/params.go 86.22% <ø> (ø)
pkg/context/opqueue/opqueue.go 80.60% <63.63%> (-0.16%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fqutishat fqutishat merged commit 23f5800 into trustbloc:main May 29, 2023
11 of 12 checks passed
@bstasyszyn bstasyszyn deleted the 1567 branch May 29, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operation Queue record has expiryTime set to 0 after operation is detached
2 participants