Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Re-select witnesses if offer fails due to witness error #965

Merged
merged 1 commit into from
Jan 7, 2022
Merged

feat: Re-select witnesses if offer fails due to witness error #965

merged 1 commit into from
Jan 7, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Dec 17, 2021 •
edited

Required changes:

  • anchor(vc) status store to delete 'in-process' status upon receiving 'completed' status
  • witness store to expose update selection status for witnesses
  • policy inspector will retrieve anchor witnesses, inspect which selected witness didn't receive proof yet and send offer to additional witnesses
  • anchor status store will expose function CheckInProcessAnchors() to determine anchors with 'in-process' status and status check time > server time
  • register anchor status store function CheckInProcessAnchors() with generic task scheduling service
  • BDD test

Closes #911

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Dec 17, 2021
@codecov
Copy link

codecov bot commented Dec 17, 2021 •
edited

Codecov Report

Merging #965 (114d2fc) into main (7b7d567) will increase coverage by 0.08%.
The diff coverage is 96.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
+ Coverage   89.25%   89.33%   +0.08%     
==========================================
  Files         159      160       +1     
  Lines       15281    15530     +249     
==========================================
+ Hits        13639    13874     +235     
- Misses       1003     1012       +9     
- Partials      639      644       +5
Impacted Files Coverage Δ
pkg/anchor/witness/proof/proof.go 100.00% <ø> (ø)
cmd/orb-server/startcmd/start.go 73.60% <84.37%> (-0.02%) ⬇️
pkg/store/anchoreventstatus/store.go 96.47% <96.47%> (ø)
pkg/anchor/witness/policy/inspector/inspector.go 97.87% <97.87%> (ø)
cmd/orb-server/startcmd/params.go 81.30% <100.00%> (+0.35%) ⬆️
pkg/anchor/handler/proof/handler.go 84.34% <100.00%> (ø)
pkg/anchor/witness/policy/policy.go 98.74% <100.00%> (+0.04%) ⬆️
pkg/anchor/writer/writer.go 91.60% <100.00%> (+0.02%) ⬆️
pkg/store/witness/witness.go 91.66% <100.00%> (+0.75%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 90.90% <0.00%> (-9.10%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7d567...114d2fc. Read the comment docs.

@sandrask sandrask changed the title feat: Re-select witnesses if offer fails due to witness error wip: Re-select witnesses if offer fails due to witness error Dec 17, 2021
@sandrask sandrask force-pushed the issue-911 branch 5 times, most recently from 5327b2b to 0393f1e Compare January 4, 2022 22:10
@sandrask sandrask changed the title wip: Re-select witnesses if offer fails due to witness error feat: Re-select witnesses if offer fails due to witness error Jan 5, 2022
@sandrask sandrask force-pushed the issue-911 branch 2 times, most recently from d189ed5 to 85f7011 Compare January 6, 2022 23:20
@sandrask
feat: Re-select witnesses if offer fails due to witness error
114d2fc 
Required changes:
- anchor(vc) status store to delete 'in-process' status upon receiving 'completed' status (done)
- witness store to expose update selection status for witnesses (done)
- policy inspector will retrieve anchor witnesses, inpect which selected witness didn't receive proof yet and send offer to additional witnesses (done)
- anchor(vc) status store will expose function checkInProcessAnchors() to determine anchors with 'in-process' status and status check time > server time (not fully completed)
- register vc status store function checInProcessAnchors() with generic task scheduling service (TODO)
- BDD test (TODO)

Closes trustbloc#911

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask merged commit abe8fe8 into trustbloc:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqutishat fqutishat fqutishat approved these changes

@bstasyszyn bstasyszyn bstasyszyn approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-select witnesses if offer fails due to witness error
3 participants
@sandrask @fqutishat @bstasyszyn