Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added max retries to operation #973

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

bstasyszyn
Copy link
Contributor

After an operation has been retried for a number of times greater than the max retry count, it will be abandoned in order to prevent a situation where retries are infinite.

closes #971

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

After an operation has been retried for a number of times greater than the max retry count then it will be abandoned in order to prevent a situation where retries are infinite.

closes trustbloc#971

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Dec 20, 2021
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #973 (0ba719a) into main (44c70de) will increase coverage by 0.08%.
The diff coverage is 87.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
+ Coverage   89.31%   89.39%   +0.08%     
==========================================
  Files         159      159              
  Lines       15169    15191      +22     
==========================================
+ Hits        13548    13580      +32     
+ Misses        989      981       -8     
+ Partials      632      630       -2     
Impacted Files Coverage Δ
pkg/context/opqueue/opqueue.go 82.60% <87.32%> (-0.07%) ⬇️
pkg/observer/pubsub.go 97.24% <0.00%> (+2.75%) ⬆️
pkg/activitypub/service/monitoring/monitoring.go 80.18% <0.00%> (+2.83%) ⬆️
...pub/service/inbox/httpsubscriber/httpsubscriber.go 100.00% <0.00%> (+9.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c70de...0ba719a. Read the comment docs.

@fqutishat fqutishat merged commit 286cd6b into trustbloc:main Dec 21, 2021
@bstasyszyn bstasyszyn deleted the 971 branch December 21, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add max retries to operations in operation queue
2 participants