Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consolidate usage of kms and crypto into a wrapper package #21

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

Moopli
Copy link
Contributor

@Moopli Moopli commented Sep 19, 2023

A few exceptions remain, as they're used by downstream projects. These are now deprecated, with replacements provided that use the new wrapper api.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 72.52% and project coverage change: -0.79% ⚠️

Comparison is base (9a6d6c1) 85.66% compared to head (aed3558) 84.87%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   85.66%   84.87%   -0.79%     
==========================================
  Files          72       72              
  Lines        8330     8325       -5     
==========================================
- Hits         7136     7066      -70     
- Misses        942     1001      +59     
- Partials      252      258       +6     
Files Changed Coverage Δ
internal/testutil/signatureutil/utils.go 100.00% <ø> (ø)
dataintegrity/suite/ecdsa2019/ecdsa2019.go 82.95% <44.44%> (-10.23%) ⬇️
...rnal/testutil/signatureutil/internal/signer/rsa.go 62.68% <56.00%> (ø)
...al/testutil/signatureutil/internal/signer/ecdsa.go 59.40% <64.00%> (ø)
signature/verifier/public_key_verifier.go 84.47% <72.09%> (-5.86%) ⬇️
...til/signatureutil/internal/signer/crypto_signer.go 75.00% <75.00%> (ø)
.../testutil/signatureutil/internal/signer/ed25519.go 63.33% <76.92%> (ø)
internal/testutil/signatureutil/signer.go 83.87% <83.87%> (ø)
signature/suite/suite_crypto.go 60.00% <100.00%> (-26.67%) ⬇️
verifiable/common.go 79.21% <100.00%> (+0.85%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A few exceptions remain, as they're used by downstream projects.
These are now deprecated, with replacements provided that use the new
wrapper api.

Signed-off-by: Filip Burlacu <Filip.Burlacu@gendigital.com>
@rolsonquadras rolsonquadras merged commit bc3ccbc into trustbloc:main Sep 20, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants