-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: streamline signer and verifiers, make them plugable. #28
Merged
rolsonquadras
merged 1 commit into
trustbloc:main
from
vkubiv:refactor-signature-verification
Oct 17, 2023
Merged
refactor: streamline signer and verifiers, make them plugable. #28
rolsonquadras
merged 1 commit into
trustbloc:main
from
vkubiv:refactor-signature-verification
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
+ Coverage 85.18% 87.73% +2.54%
==========================================
Files 72 53 -19
Lines 8559 7925 -634
==========================================
- Hits 7291 6953 -338
+ Misses 1002 708 -294
+ Partials 266 264 -2
☔ View full report in Codecov by Sentry. |
1226e01
to
417a5f2
Compare
Moopli
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 main things:
- One typo that I think is a bug, at proof/jwtproofs/ps256/proof.go:33
- Find&replace changed a lot of comments and strings that say things like sign, verify, signer, verifier, value; and that includes a lot of places that shouldn't change, I've tagged all I found.
Other than those, this looks good!
b99368c
to
d8e707d
Compare
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
d8e707d
to
2680e3a
Compare
Moopli
approved these changes
Oct 17, 2023
rolsonquadras
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.