Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: streamline signer and verifiers, make them plugable. #28

Merged

Conversation

vkubiv
Copy link
Contributor

@vkubiv vkubiv commented Oct 11, 2023

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (f415c5a) 85.18% compared to head (2680e3a) 87.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   85.18%   87.73%   +2.54%     
==========================================
  Files          72       53      -19     
  Lines        8559     7925     -634     
==========================================
- Hits         7291     6953     -338     
+ Misses       1002      708     -294     
+ Partials      266      264       -2     
Files Coverage Δ
crypto-ext/verifiers/ed25519/verifier.go 100.00% <100.00%> (ø)
dataintegrity/suite/ecdsa2019/ecdsa2019.go 90.68% <100.00%> (+0.17%) ⬆️
dataintegrity/verifier.go 89.88% <ø> (ø)
didconfig/verifier/didconfig.go 94.89% <100.00%> (ø)
sdjwt/holder/holder.go 97.91% <100.00%> (ø)
sdjwt/issuer/issuer.go 92.65% <100.00%> (ø)
sdjwt/verifier/verifier.go 95.47% <100.00%> (+1.56%) ⬆️
verifiable/bbs_selective_disclosure.go 71.06% <100.00%> (ø)
verifiable/common.go 82.47% <ø> (-0.86%) ⬇️
verifiable/credential_bbs.go 76.92% <100.00%> (-3.08%) ⬇️
... and 20 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vkubiv vkubiv force-pushed the refactor-signature-verification branch 7 times, most recently from 1226e01 to 417a5f2 Compare October 16, 2023 09:46
Copy link
Contributor

@Moopli Moopli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 main things:

  1. One typo that I think is a bug, at proof/jwtproofs/ps256/proof.go:33
  2. Find&replace changed a lot of comments and strings that say things like sign, verify, signer, verifier, value; and that includes a lot of places that shouldn't change, I've tagged all I found.

Other than those, this looks good!

legacy/mem/mem.go Outdated Show resolved Hide resolved
legacy/mock/storage/storage.go Outdated Show resolved Hide resolved
legacy/test/component/storage/storage.go Outdated Show resolved Hide resolved
proof/jwtproofs/ps256/proof.go Outdated Show resolved Hide resolved
sdjwt/common/verification.go Outdated Show resolved Hide resolved
verifiable/data_integrity_proof.go Outdated Show resolved Hide resolved
verifiable/data_integrity_proof_test.go Outdated Show resolved Hide resolved
verifiable/embedded_proof.go Outdated Show resolved Hide resolved
verifiable/embedded_proof_test.go Outdated Show resolved Hide resolved
verifiable/presentation.go Outdated Show resolved Hide resolved
@vkubiv vkubiv force-pushed the refactor-signature-verification branch 6 times, most recently from b99368c to d8e707d Compare October 17, 2023 06:28
Signed-off-by: Volodymyr Kubiv <volodymyr.kubiv@euristiq.com>
@vkubiv vkubiv force-pushed the refactor-signature-verification branch from d8e707d to 2680e3a Compare October 17, 2023 13:55
@rolsonquadras rolsonquadras merged commit 9798eb5 into trustbloc:main Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants