Skip to content
This repository has been archived by the owner on Aug 25, 2023. It is now read-only.

feat: changes to add key alias support #342

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

rajeshkalaria80
Copy link
Contributor

No description provided.

@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

pkg/aws/opts_test.go Outdated Show resolved Hide resolved
pkg/aws/opts_test.go Outdated Show resolved Hide resolved
pkg/env/util.go Outdated Show resolved Hide resolved
@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@rajeshkalaria80 rajeshkalaria80 changed the title DRAFT: changes to add key alias support changes to add key alias support Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 85.49% // Head: 85.51% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (6ec004f) compared to base (f895f91).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   85.49%   85.51%   +0.02%     
==========================================
  Files          24       25       +1     
  Lines        2130     2147      +17     
==========================================
+ Hits         1821     1836      +15     
- Misses        203      204       +1     
- Partials      106      107       +1     
Impacted Files Coverage Δ
pkg/aws/service.go 65.15% <81.81%> (+0.92%) ⬆️
pkg/aws/opts.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

Signed-off-by: Rajesh Kalaria <rajesh.kalaria@gmail.com>
@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@fqutishat fqutishat changed the title changes to add key alias support feat: changes to add key alias support Dec 5, 2022
@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

Signed-off-by: Rajesh Kalaria <rajesh.kalaria@gmail.com>
@cla-bot
Copy link

cla-bot bot commented Dec 5, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@fqutishat fqutishat merged commit 50a50d5 into trustbloc:main Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants