Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miltertest: Fix broken mt.data() function #55

Merged
merged 1 commit into from Oct 16, 2020

Conversation

glts
Copy link

@glts glts commented Dec 24, 2019

The implementation of mt.data() is broken. The state management uses the
wrong constants, thereby causing any use of mt.data() to time out:

miltertest: select(): timeout on fd 3

The fix is straightforward. Align the mistaken use of STATE_* constants
in mt_data and mt_header with how it’s done elsewhere.

@glts glts changed the base branch from master to develop December 27, 2019 13:56
@glts
Copy link
Author

glts commented Jul 26, 2020

I want to point out that miltertest cannot currently be used to test
milters that use the data stage due to this bug. This impacts the
usefulness of miltertest considerably.

The fix is trivial, so it would be great if you could find the time to
merge this.

@martinbogo
Copy link

Looks good, doesn't break the tests, so merging.

@martinbogo martinbogo merged commit 266fcb9 into trusteddomainproject:develop Oct 16, 2020
@glts
Copy link
Author

glts commented Oct 16, 2020

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants