Minor updates for lua 5.3 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple changes to all the LUA_VERSION_NUM == 502 tests throughout the code to make them >= 502, to allow for lua 5.3. In addition, lua 5.3 changed the signature for lua_dump() to add a strip parameter. In those cases, call the new signature with strip = 0 to retain the old behavior. This is necessary to properly build on centos 8, Fedora 31 and above with lua 5.3. Based on a patch in the Fedora tree by Breno Brand Fernandes brandfbb@gmail.com which replaced the problematic calls with one for the new version of lua. This patch maintains backwards compatibility with older versions of lua, should that be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple changes to all the LUA_VERSION_NUM == 502 tests throughout the
code to make them >= 502, to allow for lua 5.3. In addition, lua 5.3
changed the signature for lua_dump() to add a strip parameter. In
those cases, call the new signature with strip = 0 to retain the old
behavior.
This is necessary to properly build on centos 8, Fedora 31 and above
with lua 5.3. Based on a patch in the Fedora tree by Breno Brand
Fernandes brandfbb@gmail.com which replaced the problematic
calls with one for the new version of lua. This patch maintains
backwards compatibility with older versions of lua, should that
be necessary.