Fix a few potential crashes #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klusark
commented
Jul 3, 2019
klusark
commented
- Fix missing from_domain check for store_dkim
- Add checks for longer than buffer while parsing record
added 3 commits
July 3, 2019 11:27
opendmarc_policy_store_dkim uses from_domain, but it assumes it has always been set before the function is called. Instead, check it has actually been set and error out of it has not.
If a long or malformed DMARC record is parsed, the code ends up checking for the strlen of NULL pointer. Correct that, and return that the policy is invalid.
This simulates the case that was fixed in the previous commit
|
Compiling and testing this. |
|
Joel, we have to do this one patch at a time. I'm going to break this up into three PR's ( one per ) |
|
@martinbogo Sounds good. I can split it up as well if you like. |
|
If you could take the time, I would definitely appreciate it. It makes my
job as a maintainer easier!
…On Mon, Jun 1, 2020 at 9:05 AM Joel Teichroeb ***@***.***> wrote:
@martinbogo <https://github.com/martinbogo> Sounds good. I can split it
up as well if you like.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5KKLKDQH53NODUL4OSBDRUOYRDANCNFSM4H5BDI3Q>
.
|
|
@martinbogo I've opend #55 and #56. The second one has two of the commits since the last commit just adds a test. |
|
Looks good, thank you
…On Mon, Jun 1, 2020 at 10:57 AM Joel Teichroeb ***@***.***> wrote:
@martinbogo <https://github.com/martinbogo> I've opend #55
<#55> and #56
<#56>. The second
one has two of the commits since the last commit just adds a test.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB5KKILK536FUATNBDKZP3RUPFWPANCNFSM4H5BDI3Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.