This repository has been archived by the owner on May 24, 2023. It is now read-only.
New Product Review views & checkout card #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
July 4, 2016 18:07
created an abstract (more or less) base view class that can be used to more easily subclass views suited for our loading mechanisms started a private internal base view (non abstract) for product grades. added necessary category for TRSNetworkAgent. refactored shop grade stuff into own category for TRSNetworkAgent. refactored tests for the latter thing. added commons category to TRSNetworkAgent (error handling etc.)
added missing UI orientation to example project (this sometimes threw a warning, but not always... weird)
split headers into private and (soon to be public) parts added error checking & handling basic data view
moved some documentation into private headers implemented SKU hashing function and finished ProductGrade category for TRSNetworkAgent updated example project to show view
alignment and example for 1 line mode is missing
updated tests for smaller possible stars minor cleanup in comments
also included creation or take over dates in headers of test (so one can see who is responsible)
also found and fixed a mocking mistake I made in private basic data view
…ong designated initializer, derp)
re-added the deprecated error code symbols and marked them accordingly
added better appledoc way (well... "better") to mark deprecated error symbols.
…is bigger than the default lightbox) added tests for that prepared readme and changelog for release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Jira Tickets APP-306 and APP-299 at once.
Now we have product review views and the card shown during checkout adapts its dimensions (mostly its height, the width still needs to be fixed in the actual code that generates the card, i.e. in the backend)