Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of redundant SQL statements inserting packages #177

Closed
ctron opened this issue Apr 17, 2024 · 1 comment
Closed

Reduce the number of redundant SQL statements inserting packages #177

ctron opened this issue Apr 17, 2024 · 1 comment

Comments

@ctron
Copy link
Contributor

ctron commented Apr 17, 2024

Navigating through the Graph code, I see the following pattern:

  • get_foo -> if Some -> return foo
  • ingest parent of foo
  • add foo to parent
    • get_foo -> if Some -> return foo
    • insert foo -> return foo

That patterns nests into the parent structures.

Without having a concrete idea, I have the expectation that we could at least eliminate the second get. As for a medium sized SBOM we have ~8000 of those calls, I think it makes sense to improve the performance.

@ctron
Copy link
Contributor Author

ctron commented Jun 25, 2024

I think that not too bad at this point.

@ctron ctron closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant