Ingestion fixes, auto-create vulnerabilities using upsert #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
force-pushed
the
feature/reingest_osv_1
branch
2 times, most recently
from
d052c8d
to
07dd1ef
Compare
Deleting the function altogether would lead a gap for e.g. testing. Also see: trustification#531 (comment)
ctron
force-pushed
the
feature/reingest_osv_1
branch
from
07cd69a
to
c8f31f8
Compare
ctron
changed the title
dejanb
approved these changes
Jul 15, 2024
bobmcwhirter
approved these changes
Jul 15, 2024
| impl super::Graph { | ||
| impl Graph { | ||
| #[instrument(skip(self, tx), err)] | ||
| pub async fn get_organizations( |
There was a problem hiding this comment.
related: I'd still argue we should be deleting get_plurals() and defer that ish to the appropriate fundamental Service.
There was a problem hiding this comment.
Created a tracking issue: #547
Ah yes. I'll fix this as part of this PR. |
Align the code with the ingestion module, only returning actual vulnerabilities.
ctron
force-pushed
the
feature/reingest_osv_1
branch
from
ef72fe9
to
8faa1c5
Compare
|
@bobmcwhirter I updated the PR and dropped the special handling for the advisory_vulns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few tests for re-ingesting documents. It also fixes issues alongside those. Most notably, it auto-creates vulnerabilities and switches the creation of those to an upsert model.