-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the 'os.detected.arch' property for s390 and s390x #43
Conversation
@trustin Could you please check? |
@trustin Could you please have a look? |
Hi! Sorry I'm late. Is |
@trustin eg: https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.12.1/ Please let me know your comments. |
I see a similar issue with i686 vs x86_32. Instead of breaking backward compatibility, how about adding some mapping configuration that allows a user to map certain values ( |
I am not sure whether I can follow above suggestion correctly. |
@namrata-ibm Sorry for a late reply. I meant letting a user create a file ( arch.s390_32=s390
arch.s390_64=s390x .. so that this plugin picks this file up. |
@trustin so this would mean creating above file in every project which uses this plugin? |
Yes, because I assume there are projects that use |
@trustin tried searching but seems difficult to determine who all use this in production already. Hence will close this PR as handling it at project level seems a safer approach. |
os.detected.arch on s390 is returned as
s390_32
and for s390x it is returned ass390_64
which needs to be corrected. This PR is for fixing the same.