Graph #42
Merged
Graph #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xudong-Huang
suggested changes
May 2, 2018
src/graph.rs
Outdated
| pub fn determine_if_included( | ||
| db: &Connection, | ||
| earlier_unit: &String, | ||
| later_units: &[&String], |
There was a problem hiding this comment.
this should be &[String] or you have construct a ref vec which is unnecessary
| .iter() | ||
| .map(|s| format!("'{}'", s)) | ||
| .collect::<Vec<_>>() | ||
| .join(", "); |
There was a problem hiding this comment.
you construct start_unit_list from star_unit which seems wrong, should be construct from later_units, or you have wrongly initialized start unit.
src/graph.rs
Outdated
| new_start_units.dedup(); | ||
| start_units = new_start_units; | ||
| } else { | ||
| break 'go_up; |
There was a problem hiding this comment.
here should be break with no label or return Ok(false). break 'go_up' we will have a infinite loop!
| determine_if_included(db, earlier_unit, later_units) | ||
| } | ||
|
|
||
| pub fn read_descendant_units_by_authors_before_mc_index( |
There was a problem hiding this comment.
recheck the issues in determineIfIncluded
Xudong-Huang
suggested changes
May 2, 2018
src/graph.rs
Outdated
| if new_start_units.len() > 0 { | ||
| start_units = new_start_units; | ||
| } else { | ||
| break 'go_down; |
There was a problem hiding this comment.
change this, find all the break with a label, and correct them
src/graph.rs
Outdated
| db: &Connection, | ||
| earlier_unit: String, | ||
| later_units: &[String], | ||
| ) -> Result<bool> { |
There was a problem hiding this comment.
you should prefix unused variables with _ to remove warnings
Xudong-Huang
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leave storage.read_props_of_units() as unimplemented.