Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Ack addtnl form of interop that's important: with legacy tech #11

Merged
merged 2 commits into from Nov 3, 2022

Conversation

dhh1128
Copy link
Contributor

@dhh1128 dhh1128 commented Aug 10, 2022

Signed-off-by: Daniel Hardman daniel.hardman@gmail.com

This replaces a comment I left in the google doc version of the spec, before I noticed @talltree 's comment that it was frozen and the content should be managed here in Github.

BTW, I have some open comments from section 6 in that same document. There is no comment from Drummond indicating that that section is locked. But I can submit a PR with those comments, if this is the canonical place for that section as well. What do you advise?

Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
@andorsk andorsk added type: content The issue involves normative content; resolution requires group consensus. status: needs-review labels Oct 17, 2022
@andorsk
Copy link
Contributor

andorsk commented Oct 17, 2022

This needs to be merged with main. Was there a reason this hasn't been merged yet? @wenjing would you like to review this ( it was made in August ) or should someone else do so ( I'm happy to help review it ) ? @dhh1128 mind resolving any conflicts so we can get this into main?

@andorsk andorsk added the status: unassigned The issue is new and has not yet been assigned to anyone. label Oct 17, 2022
Signed-off-by: Daniel Hardman <daniel.hardman@gmail.com>
@dhh1128
Copy link
Contributor Author

dhh1128 commented Oct 17, 2022

Merge conflicts resolved.

@andorsk
Copy link
Contributor

andorsk commented Oct 17, 2022

Thanks @dhh1128 !

@andorsk andorsk self-requested a review October 19, 2022 07:30
Copy link
Contributor

@andorsk andorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I'd like one a view on it from one other person though before we merge. Will add a few more reviewers.

Copy link
Collaborator

@talltree talltree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andorsk andorsk merged commit dc52ce5 into trustoverip:main Nov 3, 2022
@andorsk
Copy link
Contributor

andorsk commented Nov 3, 2022

Merged based on TechArch discussion Nov 3.

spec.md Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: needs-review status: unassigned The issue is new and has not yet been assigned to anyone. type: content The issue involves normative content; resolution requires group consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants