Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're planning to expand the team, I thought I'd draft a CONTRIBUTING.md to codify developer practices and hopefully avoid some redundant questions as new folks join. Let me know what you think!
Some proposals:
What do you think of letting non-@hal909 team members review obvious and minor PRs? This would let us fix merge conflict CircleCI breakages, add documentation, fix typos, etc. without being blocked on Hal. But all
dev
feature development, refactoring, contract logic changes, etc. would still need Hal's approval.Right now we've got 77 branches. Could we make it okay to delete merged and stale (>1 month) branches? If people want to back up a branch, they can do so locally or onto a personal fork.
I think we should encourage generating docs and flattened contracts as much as possible, without slowing down dev work by requiring these as we do with CircleCI checks. Flattened files falling out of sync introduces room for deploy error.
Deploying to Ropsten should also be as frictionless as possible, to speed up testing and reduce deploy errors because we frequently stress test it. Ideally something like
yarn deploy --ropsten FooContract
, which:All we would have to do is commit and submit a PR. Later we might also upgrade by script: