Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PathFund logo to Trustwallet #8804

Closed
wants to merge 4 commits into from
Closed

Conversation

PathFund
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented May 27, 2021

PR Summary
Files in PR: 2
Token in PR: BEP20 0x9974F4E6FF49ac39469928E5d7cCa3E8649ae6b8
Could not retrieve info file; PathFund/assets/master 0x9974F4E6FF49ac39469928E5d7cCa3E8649ae6b8, SyntaxError: Unexpected token  in JSON at position 0

@ghost
Copy link

ghost commented May 27, 2021

Hi! In order to compensate for the efforts of processing PRs, we kindly ask for a contribution.
💀 As there is no refund, before paying the fee, make sure new tokens fulfill the minimum circulation and other acceptance criteria.
See also the PR Fee FAQ.

Please pay 250 TWT with the memo 8804 to the address bnb1tqq9llyr3dyjd559dha6z5r5etk3qfwk07m098.
Alternatively, 2 BNB is also accepted (same memo & address).

QR code: Trust | other wallet

Notes:

  • Trust Wallet Tokens (TWT) can be obtained through our Referral Program or from DEXs/exchanges.
  • New tokens without significant usage are rejected, see criteria mentioned above.
  • One PR should be for a single project; PR's with more than 10 logos will be rejected.
  • Payment evaluation happens automatically, but with a few minutes delay. When payment is detected, an Accept Review is automatically placed on the PR, which is a condition for merge.
  • Evaluating the PR is done manually, and it is merged only if all conditions are satisfied.
  • TWT-BEP2 is supported (Binance Chain), TWT-BEP20 version on Smart Chain is not.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fee paid, review added.

@ghost
Copy link

ghost commented May 27, 2021

Fee is PAID, fantastic! Thanks!

The PR will be evaluated soon by a maintainer, and if merged, the new logos should be visible in Trust Wallet.
Please note that the app caches logos (up to several days; if you want to see changes immediately, use a new installation). See the assets FAQ.
(@zachzwei, @catenocrypt & @Iamdeadlyz: please take note.)

(250 TWT)

@ghost ghost added the Payment Status: Paid Fee completely paid for PR label May 27, 2021
@ghost
Copy link

ghost commented May 27, 2021

PR Summary
Files in PR: 2
Token in PR: BEP20 0x9974F4E6FF49ac39469928E5d7cCa3E8649ae6b8
Could not retrieve info file; PathFund/assets/master 0x9974F4E6FF49ac39469928E5d7cCa3E8649ae6b8, SyntaxError: Unexpected token
in JSON at position 65

@PathFund
Copy link
Contributor Author

What seems to be the problem in this case?
Thanks in advance.

@PathFund
Copy link
Contributor Author

Do we have to submit a new PR or can we modify this one and it will be reviewed later?

Added correct info.json
@ghost
Copy link

ghost commented May 27, 2021

PR Summary
Files in PR: 2
Token in PR: BEP20 0x9974F4E6FF49ac39469928E5d7cCa3E8649ae6b8
Could not retrieve info file; PathFund/assets/master 0x9974F4E6FF49ac39469928E5d7cCa3E8649ae6b8, SyntaxError: Unexpected token
in JSON at position 68

@Cryptocool1
Copy link
Collaborator

can you please create new PR using our new Assets app in beta; go to https://assets.trustwallet.com, log on with Github, enter contract ID, logo and some additional info, and it will create a PR for you.
See https://community.trustwallet.com/t/how-to-submit-a-token-logo-using-assets-app/82957.
When creating new PR, mention this PR, so that fee can be reused, and not paid again.

@PathFund
Copy link
Contributor Author

Created PR 8817 #8817

Done @Cryptocool1

Thank you very much!

@PathFund PathFund mentioned this pull request May 27, 2021
@PathFund
Copy link
Contributor Author

Good morning, is everything alright with the other PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants