This repository has been archived by the owner on May 28, 2019. It is now read-only.
Refactor PublicKey and Blockchain #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to add new blockchains.
vikmeup
reviewed
Sep 6, 2018
Sources/BlockchainFactory.swift
Outdated
| case 5718350: | ||
| return Wanchain() | ||
| default: | ||
| return nil |
There was a problem hiding this comment.
can we do fatal error instead?
madcake
approved these changes
Sep 6, 2018
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
========================================
- Coverage 83.33% 81% -2.34%
========================================
Files 67 71 +4
Lines 2826 2879 +53
========================================
- Hits 2355 2332 -23
- Misses 471 547 +76
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to add new blockchains.