This repository has been archived by the owner on May 28, 2019. It is now read-only.
Conform Bitcoin to BIP49 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
alejandro-isaza
approved these changes
Sep 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
Coverage ? 80.97%
=========================================
Files ? 73
Lines ? 2906
Branches ? 0
=========================================
Hits ? 2353
Misses ? 553
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -9,8 +9,10 @@ import Foundation | |||
| public extension PublicKey { | |||
| /// Returns the public key address with the given prefix. | |||
| public func bitcoinAddress(prefix: UInt8) -> BitcoinAddress { | |||
| let hash = Data([prefix]) + Crypto.sha256ripemd160(data) | |||
| return BitcoinAddress(data: hash)! | |||
| let witnessVersion = Data([0x00] + [0x14]) | |||
There was a problem hiding this comment.
Data(bytes: [0x00, 0x14])
| let hash = Data([prefix]) + Crypto.sha256ripemd160(data) | ||
| return BitcoinAddress(data: hash)! | ||
| let witnessVersion = Data([0x00] + [0x14]) | ||
| let redeemScript = Crypto.sha256ripemd160(witnessVersion + bitcoinKeyHash) |
There was a problem hiding this comment.
Since this is specific to p2sh-p2wpkh is should be on a separate function: bitcoinSegWitAddress?
alejandro-isaza
approved these changes
Sep 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.