Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++]: Fix incorrect use of noexcept specifier #3347

Open
satoshiotomakan opened this issue Aug 2, 2023 · 2 comments
Open

[C++]: Fix incorrect use of noexcept specifier #3347

satoshiotomakan opened this issue Aug 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@satoshiotomakan
Copy link
Collaborator

Describe the bug
WC makes the end-user app crashing because of the incorrect use of C++ noexcept specifier which ignores throw exceptions.

To Reproduce
For example, pass an incorrect EOS signature:

tx.signatures.emplace_back(Signature(signature, type));

Expected behavior
WC should either throw an exception or return an error in SigningOutput { error, error_message } Protobuf message.

@satoshiotomakan satoshiotomakan added the bug Something isn't working label Aug 2, 2023
@ngqinzhe
Copy link

ngqinzhe commented Aug 9, 2023

can I try this? is this issue specifically targeting EOS?

@Vvipp4535
Copy link

Will this affect any core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants
@ngqinzhe @satoshiotomakan @Vvipp4535 and others