ADR-0001: TrustyAI external library integration #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielezonca
approved these changes
May 5, 2023
There was a problem hiding this comment.
Thanks @ruivieira for the proposal
It looks good to me, just some minor comments to clarify some aspects.
My votes (see Apache Voting 😄 ):
Proposal 1: +0
Probably a bit easier to implement (also because it is not going to add new deployments) but harder to extend/compose
Proposal 2 +1
It might be a bit more complex but overall I find it more clean and "future proof"
Final note:
If necessary we implement also proposal 1 in the future with some "dynamic loading" mechanism (via ServiceLoader) inside TrustyAI Service.
Co-authored-by: Daniele Zonca <dzonca@redhat.com>
Co-authored-by: Daniele Zonca <dzonca@redhat.com>
Co-authored-by: Daniele Zonca <dzonca@redhat.com>
Co-authored-by: Daniele Zonca <dzonca@redhat.com>
ruivieira
added
the
ADR/under-discussion
danielezonca
reviewed
May 5, 2023
|
5855ef1 should read "Move ADR-0001 proposal 2 into the Considered section" |
danielezonca
approved these changes
May 15, 2023
ruivieira
removed
the
ADR/under-discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Architecture Decision Record for external library integration.
The goal of this PR is to discuss which proposal to take forward.