Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add validation to base metric requests #160

Merged
merged 1 commit into from
Apr 30, 2023
Merged

feat: Add validation to base metric requests #160

merged 1 commit into from
Apr 30, 2023

Conversation

ruivieira
Copy link
Member

#159 and RHODS-7768.

Add validation to BaseMetricRequest and update unit tests accordingly.

@ruivieira ruivieira added kind/enhancement New feature or request module/service labels Apr 30, 2023
@ruivieira ruivieira added this to the TrustyAI 0.2.0 milestone Apr 30, 2023
@ruivieira ruivieira requested a review from a team as a code owner April 30, 2023 20:42
@ruivieira ruivieira self-assigned this Apr 30, 2023
@ruivieira ruivieira requested review from tteofili and RobGeada and removed request for a team April 30, 2023 20:42
@ruivieira ruivieira mentioned this pull request Apr 30, 2023
Closed
@ruivieira ruivieira merged commit 9e323a1 into trustyai-explainability:main Apr 30, 2023
4 checks passed
@ruivieira ruivieira deleted the RHODS-7768 branch April 30, 2023 21:13
@ruivieira ruivieira mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielezonca danielezonca danielezonca approved these changes

@tteofili tteofili Awaiting requested review from tteofili tteofili is a code owner automatically assigned from trustyai-explainability/developers

@RobGeada RobGeada Awaiting requested review from RobGeada RobGeada is a code owner automatically assigned from trustyai-explainability/developers

Assignees

@ruivieira ruivieira

Labels
kind/enhancement New feature or request module/service
Projects
None yet
Milestone
TrustyAI 0.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruivieira @danielezonca