More comprehensive metric validation, align error message nomenclature #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobGeada
requested review from
ruivieira and
tteofili
and removed request for
a team
…styai-explainability into AlignErrorMessages
|
/test trustyai-explainability-e2e |
…styai-explainability into AlignErrorMessages
…styai-explainability into AlignErrorMessages
danielezonca
approved these changes
Aug 1, 2023
.../org/kie/trustyai/service/validators/metrics/fairness/group/GroupMetricRequestValidator.java
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielezonca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metric validation error messages now list every applicable error message, to prevent the one-error-at-a-time flow we were seeing before, and have change "outcome" to "output" to align with other sources
Addresses #271 and #247
Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
FAI-XYZ Subject[0.3.x] FAI-XYZ Subject