Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Route status #125

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat: Add Route status #125

merged 1 commit into from
Oct 17, 2023

Conversation

ruivieira
Copy link
Member

Add a RouteAvailable status with RouteNotFound and RouteFound reasons.

@ruivieira ruivieira added the kind/enhancement New feature or request label Oct 16, 2023
@ruivieira ruivieira requested review from danielezonca and a team October 16, 2023 23:16
@ruivieira ruivieira self-assigned this Oct 16, 2023
@ruivieira ruivieira requested review from tteofili and RobGeada and removed request for a team October 16, 2023 23:16
@ruivieira ruivieira linked an issue Oct 16, 2023 that may be closed by this pull request
Add Condition and Status based on Routes #43
Closed
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

@ruivieira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e de4b81b link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm label Oct 17, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RobGeada

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 964c1c5 into trustyai-explainability:main Oct 17, 2023
3 of 6 checks passed
@ruivieira ruivieira deleted the issue-43 branch October 17, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobGeada RobGeada RobGeada approved these changes

@danielezonca danielezonca Awaiting requested review from danielezonca

@tteofili tteofili Awaiting requested review from tteofili tteofili was automatically assigned from trustyai-explainability/developers

Assignees

@ruivieira ruivieira

@RobGeada RobGeada

Labels
kind/enhancement New feature or request lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Condition and Status based on Routes
2 participants
@ruivieira @RobGeada