Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsup config, fix package exports #4

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Add tsup config, fix package exports #4

merged 3 commits into from
Jan 25, 2024

Conversation

vktrl
Copy link

@vktrl vktrl commented Jan 25, 2024

Fixed:

  • package.json main points to dist/index.js which doesn't exist
  • .cjs files are built, but not pointed to

vktrl and others added 3 commits January 25, 2024 07:51
tsup config so don't need all the ops
removed other args that are already being passed
Copy link
Owner

@trvswgnr trvswgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge oversight on my part - nice catch. i did update the build script - don't need those cli args with the config right?

@trvswgnr trvswgnr merged commit 9922814 into trvswgnr:main Jan 25, 2024
2 checks passed
@vktrl
Copy link
Author

vktrl commented Jan 25, 2024

huge oversight on my part - nice catch. i did update the build script - don't need those cli args with the config right?

Yeah, you can skip those. Oversight on my end :)

@trvswgnr
Copy link
Owner

@vktrl what's your xitter handle? and why aren't you showing up as a contributor?

@vktrl
Copy link
Author

vktrl commented Jan 25, 2024

@vktrl what's your xitter handle?

I'm just a lurker, no point in doxxing myself. I'm building a product for my SaaS startup though and may get back to you if I end up using the library and/or contribute enough to get credited as an user or a contributor.

and why aren't you showing up as a contributor?

I don't know, probably caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants