Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filters to send API types #136

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Add filters to send API types #136

merged 1 commit into from
Jul 10, 2023

Conversation

tk26
Copy link
Contributor

@tk26 tk26 commented Jul 10, 2023

Description of the change

Add filters to send API types

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@linear
Copy link

linear bot commented Jul 10, 2023

C-9890 SDK changes: Send to account, list and audience filters

https://www.notion.so/trycourier/Accounts-Milestones-e580c62eaa7e4c74a3127f5fa9015405

milestone 5 and 6

Only focus on Node and PHP changes rn

Includes preferences changes

@tk26 tk26 self-assigned this Jul 10, 2023
@tk26 tk26 added the enhancement New feature or request label Jul 10, 2023
@tk26 tk26 merged commit bba102a into master Jul 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drew-y drew-y drew-y approved these changes

Assignees

@tk26 tk26

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tk26 @drew-y