Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx config to handle subdirectory installs #183

Closed
ErisDS opened this issue Apr 10, 2017 · 0 comments · Fixed by #371
Closed

Update nginx config to handle subdirectory installs #183

ErisDS opened this issue Apr 10, 2017 · 0 comments · Fixed by #371

Comments

@ErisDS
Copy link
Member

ErisDS commented Apr 10, 2017

Our configuration of nginx will need to do extra trickery if the url of a blog is configured to use a subdirectory.

Also wanted to leave a note here about the idea of having nginx config template files easily accessible in the repo, and swapping template vars in, instead of programmatically building the file.

This improves readability/understandability of what ghost-cli does, and gives us a very simple logging fall back if we run into an issue where we can't write the config automatically.

E.g. if there's already a config file or the perms are wrong, we can log the template file and tell users to update their config to match this manually.

acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#363, closes TryGhost#365, closes TryGhost#348, closes TryGhost#332, closes TryGhost#183
- move nginx configuration to templates
- rely on acme.sh for cronjobs, remove ssl-renew setup and command
- cleanup & simplify nginx setup
- add subdirectory support
acburdine added a commit to acburdine/Ghost-CLI that referenced this issue Jul 21, 2017
closes TryGhost#363, closes TryGhost#365, closes TryGhost#348, closes TryGhost#332, closes TryGhost#183
- move nginx configuration to templates
- rely on acme.sh for cronjobs, remove ssl-renew setup and command
- cleanup & simplify nginx setup
- add subdirectory support
acburdine added a commit that referenced this issue Jul 21, 2017
closes #363, closes #365, closes #348, closes #332, closes #183
- move nginx configuration to templates
- rely on acme.sh for cronjobs, remove ssl-renew setup and command
- cleanup & simplify nginx setup
- add subdirectory support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants