Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings (Desktop/Mobile/Everything) #3

Closed
matthojo opened this issue May 7, 2013 · 1 comment
Closed

Settings (Desktop/Mobile/Everything) #3

matthojo opened this issue May 7, 2013 · 1 comment
Milestone
0.2

Comments

@matthojo
Copy link
Contributor

matthojo commented May 7, 2013

User story for settings management. This is the main screen - http://cl.ly/O6v7

  • User arrives on settings screen
  • By default the first item in the list is selected
    • Use history API to remember the last sub-section the user was on and return to it?
  • The settings relevant to the currently-active menu item are on the right
  • The user can update the settings, and save them with the save button, top-right
    • Do we need a save button?
  • Clicking on menu items on the left dynamically loads in the settings for other areas

Tablet workflow: Exactly the same, but smaller columns http://cl.ly/O6sC

Mobile workflow: Split into 2 pages, like other screens detailed http://cl.ly/O7TY
@ghost ghost assigned ErisDS May 7, 2013
@JohnONolan
Copy link
Member

This is done. New issues for anything specific.

ErisDS pushed a commit that referenced this issue Mar 4, 2014
@grillorafael
Merge pull request #3 from Rahmon/patch-3
6002e97 
Update configuration.html
ErisDS pushed a commit that referenced this issue Mar 30, 2014
@thiagotomasi
Merge pull request #3 from thiagotomasi/gh-pages-ptbr
43c0d4e 
[Translations: /pt-BR] Portuguese translation for Ghost documentation
@gleneivey gleneivey mentioned this issue Oct 28, 2014
Closed
cobbspur pushed a commit to cobbspur/Ghost that referenced this issue May 18, 2015
@JohnONolan
Merge pull request TryGhost#3 from JohnONolan/myth
46d8ad2 
Myth
@juan-g juan-g mentioned this issue Apr 27, 2017
Closed
kirrg001 added a commit to kirrg001/Ghost that referenced this issue Feb 15, 2018
@kirrg001
Removed isNew usages in model layer
8b5e1c9 
no issue

- `isNew` does not work in Ghost, because Ghost does not use auto increment id's
- see bookshelf/bookshelf#1265
- see https://github.com/bookshelf/bookshelf/blob/0.10.3/src/base/model.js#L211
- we only had one occurance, which was anyway redundant
  - if you add a user, `hasChanged('password') is true
  - if you edit a user and the password has changed, `hasChanged('password')` is true as well

NOTE #1:

1. We can't override `isNew` and throw an error, because bookshelf makes use of `isNew` as well, but it's a fallback if `options.method` is not set.
2. It's hard to re-implement `isNew` based on `options.method`, because then we need to ensure that this value is always set (requires a couple of changes)

NOTE TryGhost#2:
If we need to differentiate if a model is new or edited, we should manually check for `options.method === insert`.

NOTE TryGhost#3:
The unit tests are much faster compared to the model integration tests.
I did a comparision with the same test assertion:
  - unit test takes 70ms
  - integration test takes 190ms
kirrg001 added a commit that referenced this issue Feb 15, 2018
@kirrg001
Removed isNew usages in model layer
355ef54 
no issue

- `isNew` does not work in Ghost, because Ghost does not use auto increment id's
- see bookshelf/bookshelf#1265
- see https://github.com/bookshelf/bookshelf/blob/0.10.3/src/base/model.js#L211
- we only had one occurance, which was anyway redundant
  - if you add a user, `hasChanged('password') is true
  - if you edit a user and the password has changed, `hasChanged('password')` is true as well

NOTE #1:

1. We can't override `isNew` and throw an error, because bookshelf makes use of `isNew` as well, but it's a fallback if `options.method` is not set.
2. It's hard to re-implement `isNew` based on `options.method`, because then we need to ensure that this value is always set (requires a couple of changes)

NOTE #2:
If we need to differentiate if a model is new or edited, we should manually check for `options.method === insert`.

NOTE #3:
The unit tests are much faster compared to the model integration tests.
I did a comparision with the same test assertion:
  - unit test takes 70ms
  - integration test takes 190ms
@fadeevab fadeevab mentioned this issue Apr 4, 2019
Closed
khuevu pushed a commit to khuevu/Ghost that referenced this issue Sep 17, 2019
add Reader role TryGhost#3
f5501cb
khuevu pushed a commit to khuevu/Ghost that referenced this issue Oct 8, 2019
fix broken test TryGhost#3
3fa8041
Ph1eu added a commit to USTH-Coders-Club/Ghost that referenced this issue Sep 14, 2022
@Ph1eu
fix db change TryGhost#3
4991345
@naz naz mentioned this issue May 9, 2023
Merged
daniellockyer pushed a commit that referenced this issue Jun 22, 2023
@allouis
Added ability to change title and hide comment count (#3)
f3f6b2a 
refs TryGhost/Product#1695

This allows theme developers to customise the output via the
{{comments}} helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
3 participants
@ErisDS @JohnONolan @matthojo