Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x migration beta #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

2.x migration beta #2

wants to merge 3 commits into from

Conversation

johannol
Copy link

@johannol johannol commented Jun 2, 2013

Hi Trygvea

The 2.x migration is not finished for me, but this is working:

  • Standalone for test/dev
  • In a project as plugin

Still to do:

  • Remove warning with changing deprecated stuffs
  • Improve the way to remove injected methods,

johann added 3 commits June 2, 2013 13:35
The 2.x migration is not finished for me, but this is working:
- Standalone for test/dev
- In a project as plugin

Still to do: 
- Remove warning with changing deprecated stuffs 
- Improve the way to remove injected methods,
@trygvea
Copy link
Owner

trygvea commented Jun 2, 2013

Thanks for the contribution. Smart way you detect the injected/instrumented methods. But I still I get a handful of unwanted methods, namely currentGorm*Api() and initErrors/hasErrors/setErrors. Also, maybe not so important, but still part of the included test-domains, the EmbeddedPart has too many attributes.

I will look into it.

@johannol
Copy link
Author

johannol commented Jun 2, 2013

i just added the removing of warnings because of the deprecated "ConfigurationHolder"

The way to remove injected methods is still to be improved. It worked well on my projects, but indeed not so well on your more complete test case. I had also the idea to create on the fly objects to compare (more complex), or use a complete test case like your one, to reference all methods... or something else. ;-)

@huweihong
Copy link

My project is in Grails 2.2,I also need this plugin support Grails 2.

@johannol
Copy link
Author

johannol commented Jun 5, 2013

For huweihong:
My fork (https://github.com/johannol/grails-class-diagram) is now working on Grails 2, and a poll request is done to trygvea. The remaining issue is there are still some remaining Grails's injected method/attribute in some domain objects (depend of the project).

It could be released "at is" for now, or still waiting to improve this fisrt. I prefer the "release often" option, but trygvea decide. Anyway, you can compile my fork, or help us to find an idea ;)

@mgnzna
Copy link

mgnzna commented Sep 10, 2013

Hi johannol,

Do you know what is happening with this in terms of merging back into the official grails plugin? I don't know what the etiquette here is but the original version is effectively obsolete and yours works (thank you) but there's only a complicated way to get hold of it by checking the project out of github, building it and installing it.

The problem is not just about GitHub it's more about the grails plugin site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants