Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made entire row clickable #522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

made entire row clickable #522

wants to merge 1 commit into from

Conversation

allisonbusse
Copy link

Fixes #396

Proposed changes

Added link to table row instead of just first table cell
...

Link to demo, if any

https://open-transit-row.herokuapp.com/
...

@hathix
Copy link
Member

hathix commented Jan 30, 2020

It looks like you can click on the colored chips, but the mouse stays looking like a "pointer" instead of a "hand". The mouse does look like a "hand" over the rest of the row. Perhaps some small CSS tweak is needed.

Copy link
Member

@hathix hathix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few pieces of feedback:

  • As I mentioned, make sure the "chips" have a "hand" icon instead of a "pointer" icon.
  • I see that you removed the NavLink class from the route name in each row, which is good, but I think the blue-ish coloring of the route name helps it stand out in a busy UI. Can you use a <span> to give the route name a blue color again? (I think it's like class="text-primary")

Other than that, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on entire row should open route information, instead of just the route name.
2 participants