Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with ViewAction for seeking the SeekBar #149

Closed
ashutoshgngwr opened this issue Apr 30, 2020 · 0 comments · Fixed by #193
Closed

Issue with ViewAction for seeking the SeekBar #149

ashutoshgngwr opened this issue Apr 30, 2020 · 0 comments · Fixed by #193
Labels
bug Something isn't working tests Pull requests that update test cases
Milestone
0.8.x

Comments

@ashutoshgngwr
Copy link
Member

ashutoshgngwr commented Apr 30, 2020 •
edited
Loading

The following ViewAction is buggy and seek action starts and ends at incorrect positions. Tests doesn't fail because we only seek to extreme positions which somehow works fine.

https://github.com/ashutoshgngwr/noice/blob/055cd672eb3d815a740a949b697a75012f0fafec/app/src/androidTest/java/com/github/ashutoshgngwr/noice/fragment/SoundLibraryFragmentTest.kt#L64-L99
@ashutoshgngwr ashutoshgngwr added bug Something isn't working help wanted Extra attention is needed tests Pull requests that update test cases labels Apr 30, 2020
ashutoshgngwr added a commit that referenced this issue Jun 7, 2020
@ashutoshgngwr
test(app): fix UI tests and stuff
0599e95 
also resolved #149
@ashutoshgngwr ashutoshgngwr removed the help wanted Extra attention is needed label Jun 7, 2020
@ashutoshgngwr ashutoshgngwr added this to the 0.8.x milestone Jun 7, 2020
@ashutoshgngwr ashutoshgngwr mentioned this issue Jun 9, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tests Pull requests that update test cases
Projects
None yet
Milestone
0.8.x
Development

Successfully merging a pull request may close this issue.

Adds Google Cast feature trynoice/android-app
1 participant
@ashutoshgngwr