Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes crash on starting service when resuming app from background #182

Merged
merged 2 commits into from May 27, 2020

Conversation

ashutoshgngwr
Copy link
Member

Changes

  • Add a workaround as suggested here.

Testing

  • Tested on a physical device
  • Added or modified unit test cases

Others

@ashutoshgngwr ashutoshgngwr added this to the 0.7.x milestone May 27, 2020
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #182 into 0.7.x will decrease coverage by 0.45%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.7.x     #182      +/-   ##
============================================
- Coverage     82.09%   81.63%   -0.46%     
  Complexity      134      134              
============================================
  Files            12       12              
  Lines           849      855       +6     
  Branches         83       87       +4     
============================================
+ Hits            697      698       +1     
- Misses           91       92       +1     
- Partials         61       65       +4     
Impacted Files Coverage Δ Complexity Δ
...ava/com/github/ashutoshgngwr/noice/MainActivity.kt 77.31% <28.57%> (-4.00%) 18.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fc5cb...0b11d61. Read the comment docs.

@ashutoshgngwr ashutoshgngwr merged commit a340bb8 into 0.7.x May 27, 2020
@ashutoshgngwr ashutoshgngwr deleted the fix/issue/179 branch May 27, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant