Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Issue #104

Closed
mgmalana opened this issue Apr 7, 2022 · 7 comments
Closed

Dependency Issue #104

mgmalana opened this issue Apr 7, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@mgmalana
Copy link

mgmalana commented Apr 7, 2022

I'm using Norfair and another library. However, I'm getting a version conflict for rich.

Is it possible to change the dependency of norfair to be able to use higher version of rich? I'm using poetry to install norfair and I'm getting a "SolveProblemError Because norfair (0.4.0) depends on rich (>=9.10.0,<10.0.0)". I need to use at least version 11.2.0.

I can force install higher version of rich using pip but I think it would be cleaner if the dependencies are clear. Norfair seems to work fine even with higher version of rich.,

@joaqo
Copy link
Collaborator

joaqo commented Apr 8, 2022

Hi, thanks for the feedback! We're experiencing some issues with our installation flow in general, so this feedback is really useful for us to consider this case in our fixes. Would you mind sharing which other dependency is having issues with rich so we can test our fixes?

@mgmalana
Copy link
Author

mgmalana commented Apr 11, 2022

@joaqo thank you for your reply! I'm trying to use BentoML library. It needs rich >=11.2.0 or else the library will raise an error as described here issue. Thank you very much for your work in norfair!

@joaqo
Copy link
Collaborator

joaqo commented Apr 11, 2022

Awesome, thanks, we'll look into it!

@dekked dekked added the bug Something isn't working label Jun 27, 2022
@sebastian-correa
Copy link

We're experiencing a similar issue when trying to use norfair coupled with lightning. While norfair implicitly depends on typing-extensions(>-3.7.4,<4.0.0) due to a direct dependency on rich(>=9.10.0, <10.0.0), lightning has a direct dependency on typing-extensions(>=4.0.0, <4.3.1) [reference]. Note that lightning also places a direct constraint on rich [reference].

For the time being, we have resorted to using an older version of pip with the --no-deps flag to force the installation of the seemingly incompatible packages.

It would be very useful if you bumpednorfair's rich version.

@nmichlo
Copy link

nmichlo commented Aug 31, 2022

Please may this be prioritized. This is a major block for use with other projects.

@javiber javiber added this to In progress in Norfair Board Sep 1, 2022
@javiber
Copy link
Collaborator

javiber commented Sep 1, 2022

Hey @nmichlo We are working on this at the moment.
I will make a PR as soon as poetry finishes locking the dependencies... that might take a while

@dekked
Copy link
Member

dekked commented Sep 2, 2022

#160 is merged, so this issue is finally solved!

For now and before we do the next release on PyPI, please install Norfair from GitHub master branch.

@dekked dekked closed this as completed Sep 2, 2022
@javiber javiber moved this from In progress to Done in Norfair Board Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Norfair Board
  
Done
Development

No branches or pull requests

6 participants