Added predefined distance functions for typical cases #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
javiber
commented
Jul 29, 2022
•
javiber
commented
- added predefined functions
- allowed the Tracker to receive a distance by name
- renamed some of the distances to be more precise. For instance, what we were caling euclidean is actually frobenius
- small refactor to the tracker, separating the calculations of distances to a separate instance method. The motivation is that this will accommodate vectorized implementations easier by overwriting this new method.
- updated most of the demos, unifying some of the implementation implementations to ran Alphapose so I left it unchanged. motmetrics4norfair demo was also left unchanged because it uses a pretty custom distance, we can discuss if we want to incorporate it as another distance.
javiber
force-pushed
the
predefined_distances
branch
3 times, most recently
from
6aeaa28
to
15164e9
Compare
aguscas
reviewed
Aug 4, 2022
javiber
force-pushed
the
predefined_distances
branch
2 times, most recently
from
7d0b95a
to
7ee2857
Compare
aguscas
reviewed
Aug 8, 2022
norfair/distances.py
Outdated
| # areas - the interesection area | ||
| iou = inter_area / float(box_a_area + box_b_area - inter_area) | ||
| # Since 0 <= IoU <= 1, we define 1/IoU as a distance. | ||
| # Distance values will be in [1, inf) |
There was a problem hiding this comment.
Distance values will be in [0, 1] right? Since you did 1-IoU instead of 1/IoU
There was a problem hiding this comment.
you're right! this is from when I was doing 1/iou
aguscas
approved these changes
Aug 9, 2022
javiber
force-pushed
the
predefined_distances
branch
from
7ee2857
to
d1045ae
Compare
aguscas
force-pushed
the
predefined_distances
branch
from
d1045ae
to
fdb431f
Compare
dekked
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.