Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add right-to-left support with auto-detection #33

Merged
merged 4 commits into from
Jan 11, 2019
Merged

Conversation

MHM5000
Copy link
Contributor

@MHM5000 MHM5000 commented Jan 11, 2019

And also here is a text for testing right-to-left in Persian:

زبان فارسی یا پارسی یا همان Persian / Farsi زبانی غنی است.
بیایید با کمک یکدیگر  آن را جهانی کنیم.
زبان عربی (Arabic) و عبری (Hebrew) هم راست به چپ‌اند.

How it should render:

زبان فارسی یا پارسی یا همان Persian / Farsi زبانی غنی است.
بیایید با کمک یکدیگر آن را جهانی کنیم.
زبان عربی (Arabic) و عبری (Hebrew) هم راست به چپ‌اند.

The change in slugify.js is necessary. Otherwise, you can't have more than 1 question because of the empty slugs.

Unfortunately, this can't handle the old system anymore.

@trys
Copy link
Owner

trys commented Jan 11, 2019

Amazing! Thank you so much! This is such a cool PR to receive!

I'll give the uuid change some thought this afternoon, just need to be sure it's not going to conflict with existing data.

Copy link
Owner

@trys trys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks great! UUID's only affect new questions so that won't be problematic. I've made a tiny tweak to the copy - hope that's all okay. Going to get it merged in now!

Thanks again, it's such a cool feature to have!

@trys trys added this to In progress in Roadmap Jan 11, 2019
@trys trys merged commit 917cc5c into trys:master Jan 11, 2019
@trys trys moved this from In progress to Done in Roadmap Jan 11, 2019
@MHM5000
Copy link
Contributor Author

MHM5000 commented Jan 11, 2019

I'm really glad you liked it.

~ 2 Billion people (Mulims, Jews, Hebrews, Persians, Arabs, Urdus, Pashtos, etc.) use RTL and most of them aren't recognized in the programming world! Adobe After Effeccts still has problems with rtl languages!

Just a couple of suggestion:

  • Internationalization: Translations could get the product on more front pages than you think.
  • localization: For example in Iran, Fridays are the end of the week and we have 'Shamsi Calendar'. Arab countries and, in general, Muslims have another calendar called the 'Hijri Calendar'. I'm sure there are more calendars out there as well.
  • A timer: I personally don't have a lot of time on my hand, but documenting stuff could help me more and more. A simple clock/timer on the page could be of great help. Also, consider creating this in a way that people be able to select/create different clocks (digital/analog) and change the themes. or have a couple of options ready to go with the theme.
  • Although offline is good, simple option of syncing to dropbox/google-drive would be a great option. Still, everything should be on the client-side.
  • Markdown should be easy to implement, but a more advanced WYSIWYG editor, with a switch in settings, shouldn't hurt.
  • Todo lists should be easy to implement too.
  • We don't have letter-spacing in Persian, Arabic, Pashto and other languages that their alphabets have joined forms. It makes them ugly. Also, there are a lot of amazing open-source fonts for better Typography.
  • All of these suggestions could be simple plugins that after activation get downloaded, so the site would be as fast as it is right now. I'm not saying you should implement them all, these are just open suggestions that need more polishing. Even google's version of Hijri/Shamsi Calendars gives me headaches! They are extremely usefull, but nobody cares.

Bests

@MHM5000 MHM5000 deleted the rtl-support branch January 11, 2019 22:20
@MHM5000
Copy link
Contributor Author

MHM5000 commented Jan 11, 2019

  • The ability to password protect the entire journal could come in handy.
  • Maybe even creating multiple Journals.

@trys
Copy link
Owner

trys commented Jan 12, 2019

@MHM5000 this is mega feedback - thank you! I'm painfully ignorant so will endeavour to keep learning and improving to make my code better for all! As for these points, it would be great to move them to individual issues for discussion then to the roadmap, just so they don't get lost on a closed PR. Are you happy to do that to keep the ideas under your name? If not, I'm happy to recreate them.

@MHM5000 MHM5000 mentioned this pull request Jan 13, 2019
@MHM5000
Copy link
Contributor Author

MHM5000 commented Jan 13, 2019

I created #35. Let's talk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants