-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add right-to-left support with auto-detection #33
Conversation
Amazing! Thank you so much! This is such a cool PR to receive! I'll give the uuid change some thought this afternoon, just need to be sure it's not going to conflict with existing data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great! UUID's only affect new questions so that won't be problematic. I've made a tiny tweak to the copy - hope that's all okay. Going to get it merged in now!
Thanks again, it's such a cool feature to have!
I'm really glad you liked it. ~ 2 Billion people (Mulims, Jews, Hebrews, Persians, Arabs, Urdus, Pashtos, etc.) use RTL and most of them aren't recognized in the programming world! Adobe After Effeccts still has problems with rtl languages! Just a couple of suggestion:
Bests |
|
@MHM5000 this is mega feedback - thank you! I'm painfully ignorant so will endeavour to keep learning and improving to make my code better for all! As for these points, it would be great to move them to individual issues for discussion then to the roadmap, just so they don't get lost on a closed PR. Are you happy to do that to keep the ideas under your name? If not, I'm happy to recreate them. |
I created #35. Let's talk! |
And also here is a text for testing right-to-left in Persian:
How it should render:
بیایید با کمک یکدیگر آن را جهانی کنیم.
زبان عربی (Arabic) و عبری (Hebrew) هم راست به چپاند.
The change in
slugify.js
is necessary. Otherwise, you can't have more than 1 question because of the empty slugs.Unfortunately, this can't handle the old system anymore.