-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use visionOS SDK instead iOS SDK. #24
Conversation
Hi @noppefoxwolf , When visionOS is targeted instead of Designed for iPad, the SFSafariViewController does not seem to modal when clicking on a link. You can check if you like! |
@d-date Currently, |
@noppefoxwolf If you mean View.sheet modifier, you can gather reducers into .safari state / action. So that you can reduce modifiers into one. |
@d-date It's work fine! I made |
@noppefoxwolf Sorry, It's not my expect. @Reducer(state: .equatable)
enum Destination {
case safari(Safari)
} |
This reverts commit 812357e.
@@ -63,6 +63,8 @@ public struct ScheduleDetail { | |||
public struct ScheduleDetailView: View { | |||
|
|||
@Bindable public var store: StoreOf<ScheduleDetail> | |||
|
|||
@Environment(\.openURL) var openURL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use @dependency(.openURL) instead for Test dependency in Reducer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I use @dependency, I don't need to switch os in view because reducer can run openURL. Is it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to apply this pattern.
2133159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes It's enough! Thank you for contribution. We'll submit Vision OS version when you ready #25
@d-date Thanks! I'll commit new AppIcon Stack in other PR. |
Changes
Allow any platform
toiOS and macOS