-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a truncated session title in Japanese #33
Fix a truncated session title in Japanese #33
Conversation
I think that using |
Thanks for your comment. Yes, I checked |
I may found problem. HStack line 79 in ScrollView is not needed. and also Spacer(line 80, 108), VStack(line 81). I checked behavior on iPhone SE. Suggestion Codepublic var body: some View {
ScrollView {
VStack(alignment: .leading, spacing: 16) {
Text(LocalizedStringKey(store.title), bundle: .module)
.font(.title.bold())
Text(LocalizedStringKey(store.description), bundle: .module)
.font(.callout)
if let requirements = store.requirements {
VStack(alignment: .leading) {
Text("Requirements", bundle: .module)
.font(.subheadline.bold())
.foregroundStyle(Color.accentColor)
Text(LocalizedStringKey(requirements), bundle: .module)
.font(.callout)
}
.padding()
.overlay {
RoundedRectangle(cornerRadius: 16)
.stroke(Color.accentColor, lineWidth: 1)
}
}
speakers
}
.padding(.horizontal)
.padding(.bottom)
.frame(maxWidth: 700) // Readable content width for iPad
}
.sheet(item: $store.scope(state: \.destination?.safari, action: \.destination.safari)) { sheetStore in
SafariViewRepresentation(url: sheetStore.url)
.ignoresSafeArea()
}
} |
Hi @shimastripe @zunda-pixel , Thank you for making PR and great discussion. @shimastripe |
@d-date Of course. I'll fix it. Is the horizontal margin of the speaker section okay as suggested? It can also be done as shown on the right.
|
@shimastripe I prefer right one. Thank you! |
@d-date Thank you! I pushed the code in the right state. ( Thanks also @zunda-pixel ) |
Result
WHY
WHAT
fixedSize()
modifier.