Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add miharun to organizer #5

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Add miharun to organizer #5

merged 2 commits into from
Mar 12, 2024

Conversation

mnaruse
Copy link
Contributor

@mnaruse mnaruse commented Mar 12, 2024 •
edited

やったこと

  • 主催者ページに @mnaruse を追加
  • ついでに名前もローカライズ

スクショ

en ja

@mnaruse mnaruse added the enhancement New feature or request label Mar 12, 2024
@mnaruse mnaruse self-assigned this Mar 12, 2024
@mnaruse mnaruse requested a review from d-date March 12, 2024 14:42
@d-date
Copy link
Member

d-date commented Mar 12, 2024 •
edited

@mnaruse
To localize your name on ProfileView, modify this line to

  .navigationTitle(Text(store.organizer.name, bundle: .module))

https://github.com/tryswift/trySwiftTokyoApp/blob/main/MyLibrary/Sources/trySwiftFeature/Profile.swift#L89

@mnaruse
Copy link
Contributor Author

mnaruse commented Mar 12, 2024

@d-date
あっちょうど別ブランチで出したところでした！
34b0b8b

@mnaruse
Copy link
Contributor Author

mnaruse commented Mar 12, 2024

コンフリクト解消したらまた連絡します。

mnaruse
mnaruse commented Mar 12, 2024
View reviewed changes
Copy link
Contributor Author

@mnaruse mnaruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-date
コンフリクト解消しましたのでご確認お願いします。

@mnaruse
Merge branch 'main' into feature/miharun
fc9b75a 
# Conflicts:
#	MyLibrary/Sources/DataClient/Resources/organizers.json
#	MyLibrary/Sources/trySwiftFeature/Localizable.xcstrings
@d-date d-date merged commit 95740aa into main Mar 12, 2024
@d-date d-date deleted the feature/miharun branch March 12, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-date d-date d-date approved these changes

Assignees

@mnaruse mnaruse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mnaruse @d-date