Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add workflows for releasing helm chart #651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add workflows for releasing helm chart #651

wants to merge 1 commit into from
+153 −0

Conversation

davidspek
Copy link

@davidspek davidspek commented Jun 2, 2023 •
edited

This PR publishes the Helm chart using GitHub pages on the current repo, making it easier for people to install. This way we at Plural can more easily keep the Touca installation up to date with the helm chart in this repository. For an example of how the repo will look after this you can have a look at our fork. https://github.com/pluralsh/trytouca

For this to work a new gh-pages branch needs to be created with the following 2 files before merging this PR:

index.html:

<html>
  <head>
    <title>Touca charts repository</title>
  </head>
  <body>
    <h1>Touca charts repository</h1>
    <p>Add this repository</p>
    <pre>
      helm repo add argo https://trytouca.github.io/trytouca
    </pre>
  </body>
</html>

index.yaml:

apiVersion: v1
entries: {}
generated: ""

@davidspek
add workflows for releasing helm chart
f7277ad 
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@ghorbanzade
Copy link
Member

Hi @davidspek, thanks for this. Are you proposing using GitHub pages simply because it's convenient to deploy to it from the CI? Wouldn't it be better if we deployed to somewhere like https://touca.io/install/helm?

@davidspek
Copy link
Author

Hi @ghorbanzade. GH pages is just an easy way to host helm charts so people can install them. Usually you wouldn't checkout a repo to install a helm chart. By hosting the helm chart somewhere we at Plural we can simply have a dependency on this helm chart allowing us to stay up to date more easily.

You could host the helm chart at another location, but I can't really help setting up the automation for that. I'm guessing hosting the helm chart somewhere probably isn't a huge priority for you currently, but I think it might be worth putting the effort into it since it would allow users to try touca much more easily.

@ghorbanzade
Copy link
Member

Thanks again, @davidspek. We have a bit of CI logic that generates a template and uploads it to S3 (see here). But it's incomplete because certain values and parameters are hard-coded. It appears your PR is taking care of fixing that. My preference is to use your PR to update that CI logic (instead of adding a new GitHub Actions workflow and using GitHub Pages). I have nothing against using Pages but since this is a monorepo, it's not ideal to deploy helm to Pages.

Let me try to update our existing CI logic tonight and if that didn't meet Plural's requirements, we can revisit merging this PR as is.

@davidspek
Copy link
Author

Another option would be to have the helm chart live in a dedicated repo to avoid cluttering up this repo. Or just have the helm chart releases live in another repo where GH pages lives. However, I'm not sure what your opinions are about this and I couldn't create a PR for creating a new repo obviously.

@davidspek
Copy link
Author

@ghorbanzade Were you able to get around to implementing the logic from this PR for the existing setup already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghorbanzade ghorbanzade Awaiting requested review from ghorbanzade ghorbanzade is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidspek @ghorbanzade