Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to specify game in multi-romset #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Mar 6, 2024

new optional argument -game is useful for selecting a specific game from a romset zip file that contains multiple versions.

@trzy
Copy link
Owner

trzy commented Mar 8, 2024

Will look at this PR this weekend. Thank you! This is a band-aid solution as far as I'm concerned. I'd like to rewrite the ROM loading system to:

  1. Continue to use load-by-CRC rather than filenames. Why? Because I still use ancient ROMs that are just fine except that they don't conform to the latest MAME naming convention, whatever that may be today. I suspect many are actually in this situation and have ROM sets that work fine.

  2. Allow multiple "dependent" ROMs to be specified (we currently allow one "parent"). This might need to be an entire DAG of dependencies given how things seem to be structured in MAME now.

This is actually not that conceptually difficult but it is a lot of sweat and toil. I might try to prototype this in Python first and then port it to C++ someday. I think the initial ROM set and game should be detected from the file passed and then any dependencies should be loaded from the same directory assuming the zip file is named "game.zip".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants